Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: server uploads to temporary directory #1610

Merged
merged 6 commits into from
Nov 4, 2024
Merged

fix: server uploads to temporary directory #1610

merged 6 commits into from
Nov 4, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Nov 1, 2024 •
edited
Loading

Describe Your Changes

  • Drogon does not allow us to disable uploads folder. Set it to temporary folder to not spam log when does not have permission to create uploads folder.
  • Start server before installing engine for macOS network installer
  • Stop server for network installer

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review November 1, 2024 16:16
@vansangpfiev vansangpfiev requested review from a team and hiento09 November 1, 2024 16:16
hiento09
hiento09 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vansangpfiev vansangpfiev merged commit 76d653f into dev Nov 4, 2024
15 checks passed
@vansangpfiev vansangpfiev deleted the fix/server-uploads-folder-path branch November 4, 2024 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hiento09 hiento09 hiento09 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vansangpfiev @hiento09